Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3): ensure s3api calls always output json #7

Merged
merged 3 commits into from
May 11, 2023
Merged

fix(s3): ensure s3api calls always output json #7

merged 3 commits into from
May 11, 2023
+8 −8

Conversation

kiran94
Copy link
Owner

@kiran94 kiran94 commented Apr 27, 2023 •
edited
Loading

Summary

Ensure that internal aws s3api calls always produce json output irrespective of user settings

Closes #6

Changes

  • Update list-buckets and list-objects calls to always produce json output
  • Minor amendment to test command in makefile to stop Plenary from freezing

@kiran94 kiran94 marked this pull request as ready for review May 11, 2023 20:11
@kiran94 kiran94 merged commit d5d8bd9 into main May 11, 2023
@kiran94 kiran94 deleted the fix/ensure-aws-s3-commands-use-json branch May 11, 2023 20:11
@kiran94 kiran94 mentioned this pull request May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception in get_bucket_names
1 participant
@kiran94